Introduce plugin manager static analysis file #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Psalm fix is available in vimeo/psalm#10157 |
boesing
force-pushed
the
qa/static-analysis
branch
from
a9e6991 to
a0e4aee
Compare
boesing
commented
Aug 29, 2023
boesing
force-pushed
the
qa/static-analysis
branch
from
ee7e23c to
0b2ee8a
Compare
boesing
commented
Aug 29, 2023
boesing
force-pushed
the
qa/static-analysis
branch
2 times, most recently
from
2536d01 to
4fcf1d7
Compare
boesing
force-pushed
the
qa/static-analysis
branch
2 times, most recently
from
b458dfd to
fe416be
Compare
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
To enable proper static analysis without side-effects, we are removing the container plugin here to verify provided psalm-types from `ServiceLocatorInterface` and `PluginManagerInterface` Signed-off-by: Maximilian Bösing <[email protected]>
… by `psalm.xml` Due to the way, psalm moves forward, this issue will be removed - most probably with v6. The reasoning behind this is, that `mixed` is not bad per-se, depending on how it is used. If a codebase accepts `mixed` in a method (even tho that might be revealing method complexity), that is a absolutely okay and thus, passing `mixed` and esp. assigning `mixed` is absolutely fine in case the following code is accepting mixed and/or the value is narrowed down at some point. Signed-off-by: Maximilian Bösing <[email protected]>
…er#build` The `AbstractSingleInstancePluginManager` has to always return an object as thats what it is used for. Therefore, type-narrowing here is absolutely fine and still fits liskov substitution principle. Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
boesing
force-pushed
the
qa/static-analysis
branch
from
6194496 to
9fa7191
Compare
…tion.NoAssignment` for inline var annotation Signed-off-by: Maximilian Bösing <[email protected]>
These methods were initially introduced to fix psalm issues. These were fixed in one of the more recent versions and thus these methods are redundant as of now. Signed-off-by: Maximilian Bösing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test is currently failing, I will debug this file with psalm to provide a proper fix to psalm itself.